Increase GitHub Actions build timeout to 6 hours #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te longer build processes
Contributor
There was a problem hiding this comment.
Pull Request Overview
Increases the GitHub Actions build timeout from 5 hours to 6 hours to accommodate longer build processes. This change removes the previous buffer time and utilizes the full maximum allowed timeout period.
- Increases timeout from 5h to 6h for the Python wheel build process
- Updates the comment to reflect the new timeout approach
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+183
to
+185
| # GH allows max 6h | ||
| EXIT_CODE=0 | ||
| timeout 5h python setup.py bdist_wheel --dist-dir=dist || EXIT_CODE=$? | ||
| timeout 6h python setup.py bdist_wheel --dist-dir=dist || EXIT_CODE=$? |
There was a problem hiding this comment.
Setting the timeout to exactly 6h (GitHub's maximum) removes any buffer time for cleanup operations or error handling. Consider using 5h45m to maintain a small buffer for graceful termination and cleanup processes.
github-actions
bot
requested review from
Evanwu1125,
SNHuan,
Thanksyy,
ftgreat,
juliohsu,
wubingheng111 and
zacliu2023
github-actions
bot
assigned
Evanwu1125,
ftgreat,
juliohsu,
SNHuan,
Thanksyy,
wubingheng111 and
zacliu2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the build timeout to accommodate longer build processes in GitHub Actions.